Skip to content

Small changes to HPX CI configuration

Daniel Arndt requested to merge github/fork/msimberg/hpx-ci-changes into hpx-ci

Created by: msimberg

The build configuration changes bring the build of Kokkos with tests to a slightly more reasonable ~45 minutes.

I was eventually able to reproduce the failure in the IndependentInstancesRefCounting test. I suspect that test has sort of worked by accident until now. It turns out that there is one more copy of the dummy struct held internally in HPX which gets released just after the fence resets the internal future. Resetting the future allows the last copy to be freed, but it is not guaranteed to have happened by the time the fence returns. However, it happens very soon after. Currently I can't think of a reasonable way to force it to be released before the fence returns (especially not without changes in HPX) so I've added a short sleep which in my tests almost guarantees the dummy count to have gone back to 1. Running the test a few thousand times gave me no failures anymore (without the sleep it fails within a few runs). Additionally, after https://github.com/kokkos/kokkos/pull/4241 the dummy_clear parallel for loop is actually not necessary anymore so I've removed it. @masterleinad I've added a comment in the test. Let me know if you think it needs more detail.

Merge request reports